Fix issue with missing styles for Page List in navigation. #31368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: -161 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
The Page List block can be added outside of Navigation. I wasn't able to reproduce the unstyled behavior you described in Looking at the diff it looks like you're moving the styles from Navigation Link to Navigation. I suspect I'm being naive, but can this be moved to Page List? |
Yep, the Page List when used on its own is supposed to just be a list. It's only when it's used inside the Navigation block that it should emulate menu items. That's also why the styles are intentionally not in the Page List block. By the way this issue might be specifick to block themes, i.e. try with TT1 blocks. I think it might be related to #31309. |
georgeh
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Something recently changed in trunk, so that if you have a Navigation block that contains only a Page List block inside, styles aren't output on the frontend. As soon as you add a "custom" menu item, it starts working.
To an extent, this makes sense. The CSS styles that styled menu items in both the Page List and custom page links lived inside the
navigation-linkblock style. This PR moves those menu item styles to live in thenavigationblock, so they get output regardless of your contents:It feels a teensy bit wrong to me to move menu item styles to the navigation block itself, however one could argue that it is the job of the Navigation block to make sure menu items look and behave correctly.
Mostly I would prefer to avoid the alternative: duplicating 1-1 the CSS that lives in the Navigation Link into the Page List block. If we had to do that, it would also be output twice if you included both a Page List and a Menu Item link.
How has this been tested?
Insert a Navigation block with ONLY a Page List inside (click "add all pages" in the placeholder). On this branch, menu items and submenus should still be styled correctly.
Checklist:
*.native.jsfiles for terms that need renaming or removal).