-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FormTokenField: Avoid error when maxLength value is hit #33623
Conversation
Size Change: +42 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mamaduka, to me it seems like the bug is on the TokenInput (packages/components/src/form-token-field/token-input.js) component. It is assuming an onchange is still present.
What if we change onChange={ this.onChange } to not pass anything if the component also did not receive an onChange prop?
@jorgefilipecosta, thanks for the suggestion. I agree fixing this in |
Description
Sets no-operation function as a
onChange
default for theTokenInput
component.CodeSandbox showcasing the issue - https://codesandbox.io/s/formtokenfield-dv9nb
Fixes #18463.
How has this been tested?
Temporarily added
maxLength
to theFlatTermSelector
component for testings, but probably there's a better way to do it.Types of changes
Bugfix
Checklist:
*.native.js
files for terms that need renaming or removal).