Closing the block inserter decrements block type impressions #33906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid new block badges from remaining too long, interacting with the block inserter multiple times will cause them to eventually disappear.
A higher value makes more sense now that closing the block inserter decrements the impression count by 1.
dcalhoun
added
[Feature] Inserter
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
This particular function is a React Native bridge method, which executes a callback to send back the requested data.
Merged
2 tasks
mchowning
reviewed
Aug 5, 2021
mchowning
reviewed
Aug 5, 2021
mchowning
approved these changes
Aug 5, 2021
Iterating over the block type impressions is unnecessary when the block inserter is opening.
Interacting with the block inserter is a more frequent task, so it makes sense to use a larger default impression count.
dcalhoun
deleted the
update/closing-inserter-decrements-block-type-impressions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33907. Closing the block inserter will decrement the block type impression counts. This results in blocks that are marked as "new" to slowly lose the designation as a user utilizes the block inserter over time.
How has this been tested?
Clone this branch.
Apply the below diff.
Patch Enabling New Badge
Start the server and build the Demo app to an emulator/device.
Open the block inserter, note the new "sparkles" badge on the Search, Embed, and Audio block buttons.
Insert one of the aforementioned blocks.
Open the block inserter, note the new "sparkles" badge should only be present on two of the aforementioned blocks not inserted.
Close the block inserter.
Repeat steps 6-7 9 more times.
ℹ️ Expected: the new "sparkles" badge is no longer present on any block buttons.
Screenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).