Create two-way data binding for ImageSizeControl #34649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ImageSizeControl` uses `useDimensionHandler` hook to store image dimensions. This hook accepts default values and custom values. It derives its state from them (custom values then fails over to default values). As common with derived state, a bug surfaces when custom values change, because the state remains outdated. This commit observes custom values and updates the state when they're updated.
alshakero
changed the title
Tracking default values was a mistake. I think this should be the way to go.
|
I cannot officially review this PR, but tested the proposed change and it works as expected. 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ImageSizeControlusesuseDimensionHandlerhook to store image dimensions.This hook accepts default values and custom values. It derives its state from them (custom values then fails over to default values).
As common with derived state, a bug surfaces when custom values change, because the state remains outdated.
This commit observes custom values and updates the state when they're updated.
How has this been tested?
Using a local wp instance.
Screenshots
realtime-reszie.mov
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).Fixes: Automattic/wp-calypso#54800