Migrate edit-widgets store to thunks #35110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
requested review from
draganescu,
kevin940726 and
tellthemachines
as code owners
|
Size Change: -309 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Sep 24, 2021
Mamaduka
approved these changes
Sep 24, 2021
noisysocks
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
Code looks good 👍 Glad that we're throwing controls.js in the bin. I didn't test this locally but if E2E tests pass then I'm happy since Kai did a pretty good job covering all the main widget flows.
I noticed we're missing doc comments for most of the exported actions that are being modified here. If you want bonus brownie points, maybe add these missing comments?
| * @param {number} menuId Menu ID. | ||
| * @return {Object} Action. | ||
| */ | ||
| export function getNavigationPostForMenu( menuId ) { |
Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
adamziel
force-pushed
the
thunkify/edit-widgets
branch
from
2a72b12
to
9a680d1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the edit-widgets data store to thunks, namely actions and resolvers. It also dependency on
@wordpress/data-controlsand on any other controls for that matter.How to test:
Open the widgets editor and confirm it loads and saves widgets as expected.