Polish quick inserter #35339
Merged
Polish quick inserter #35339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
jasmussen
requested review from
ajitbohra,
chrisvanpatten,
ellatrix and
noisysocks
as code owners
1 task
|
Size Change: +53 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
vcanales
reviewed
Oct 5, 2021
|
Thank you, excellent eye. I think I fixed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewing https://github.com/WordPress/gutenberg/pull/33132/files#r721964593 surfaced a few issues with paddings, margins and focus styles in the quick inserter.
It's most visible in #33132, where it looks like this:
The focus style of the Browse all button is a bit layered:
This PR addresses that by making a few changes:
GIF showing the above:
How has this been tested?
Test the quick inserter and verify it works as intended in all cases.
Checklist:
*.native.jsfiles for terms that need renaming or removal).