Scripts: Remove inject polyfill by default #35436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2.25 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
@mkaz for testing do you have an example command of what we should run / see? For other reviewers, note that the block editors request wp-polyfill regardless of this change (and that this is expected).
|
|
It is a little tricky to test because you'll need to run the wp-scripts out of the repo, and not NPM. The before case: The after case is easiest to duplicate, so working off the same before case |
|
Hmm, maybe we can leverage the create block test gutenberg/bin/test-create-block.sh Line 22 in 2c7ed62 |
gwwar
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
I tested this by commenting out this line in test-create-block and ran npm run test:create-block in this branch, then again in trunk. As we can see the wp-polyfill is omitted:
branch: esnext-test/build/index.asset.php
<?php return array('dependencies' => array('wp-block-editor', 'wp-blocks', 'wp-element', 'wp-i18n'), 'version' => 'daa4176be053b3cf84973d388f68b869');
trunk:
<?php return array('dependencies' => array('wp-block-editor', 'wp-blocks', 'wp-element', 'wp-i18n', 'wp-polyfill'), 'version' => 'daa4176be053b3cf84973d388f68b869');
aristath
requested changes
Oct 8, 2021
gziolo
approved these changes
Oct 8, 2021
Co-authored-by: Ari Stathopoulos <aristath@gmail.com>
aristath
approved these changes
Oct 8, 2021
2 tasks
2 tasks
eason9487
added a commit
to woocommerce/google-listings-and-ads
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default behavior for the scripts when generating the assets.php file was to include the
wp-polyfillby default. With the dropping of support for IE, this is no longer necessary. So this PR removes adding it by default.Fixes #35410
How has this been tested?
Confirm that when using script to generate assets.php script, that
wp-polyfillis not included in the dependency list.Types of changes
This is a breaking change in that any scripts or plugins that rely on the polyfill must now explicitly declare it as a dependency, which they probably should of done in the first place to guarentee compatibility.