Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom webpack configs since wp-polyfill is no longer included by default #15

Closed
2 tasks done
douglas-johnson opened this issue Feb 3, 2022 · 0 comments · Fixed by #16
Closed
2 tasks done
Assignees

Comments

@douglas-johnson
Copy link
Member

douglas-johnson commented Feb 3, 2022

According to this:
https://github.com/thoughtis/cata-blocks/blob/0.3.8/blocks/newsletter/webpack.config.js#L12

We were waiting for this to hit a tagged release of wp scripts because it remove wp-polyfill from front-end scripts without the need for a custom webpack config:
WordPress/gutenberg#35436

Acceptance Criteria

  • Blocks still build
  • wp-polyfill is not enqueued on the front-end as a requirment of our blocks.
@douglas-johnson douglas-johnson self-assigned this Feb 3, 2022
@douglas-johnson douglas-johnson changed the title Remove custom webpack configs since no wp-polyfill is now the default Remove custom webpack configs since wp-polyfill is no longer included by default Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant