[RNMobile][Embed Block] Revert workaround for loading glitch #35674
Conversation
fluiddot
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
|
I am currently seeing this issue on WP Android at times when I spin up this solution in metro server. So I will run the cases mentioned and the UI state changes will occur as expected and then randomly this bug appears. I am working on capturing it due to it occurring randomly. |
Right, I've just tested on an Android device and I managed to reproduce it. I guess the original issue was maybe easier to reproduce on Android 🤔 . I'll try to figure out a new approach to prevent the original issue 🔧 . |
I finally found the culprit of this behavior: We're using the selector The Click here to see code referencesgutenberg/packages/core-data/src/selectors.js Lines 42 to 46 in 752d775 gutenberg/packages/data/src/redux-store/metadata/selectors.js Lines 67 to 69 in 752d775 gutenberg/packages/data/src/redux-store/metadata/selectors.js Lines 8 to 27 in 752d775 In the following logs, you can see how the Click here to see logs
Following the approach I did for the reusable block to determine the loading state (reference), I'm going to check if the resolver has finished for this purpose. So the following |
@jd-alexander here is the PR #35798 regarding the new approach for this issue, let me know if you could take a look, thanks 🙇 . |
Thanks @fluiddot I will take a look. Thanks for the logs and explanation here about the root cause of the issue. |
|
Closing this PR in favor of #35798. |
Description
This PR reverts the changes introduced in #33574.
How has this been tested?
Follow the testing instructions from the reverted PR #33574 and verify that the original issue is not happening.
Screenshots
N/A
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).