[RNMobile][Embed Block] Fix loading glitch with resolver resolution approach #35798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
|
I'd like to note that the original issue can also be reproduced in the web editor, although in this case, the glitch is almost unnoticeable (see attached video recorded at slowmo). Click here to display the videoKapture.2021-10-20.at.12.01.06.mp4On one frame (00:05), we can see that the embed is reporting that the content couldn't be embedded but in the next frame, the preview is loading.
We might consider applying the same approach in the web version of the embed 🤔 . |
7 tasks
jd-alexander
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
Thanks for this slick glitch fix @fluiddot 🥇 I was able to verify that the issue no longer occurs on iOS or Android. LGTM 🚢
For the web, I wasn't able to reproduce but I think that is because my internet connection is good so the preview appeared instantaneously. Is Network Link Conditioner something you utilize to throttle network speed?
I agree with applying this fix to the web as well 👍🏾 |
Not sure if it would be easier to reproduce it by throttling the network speed, I haven't tested this approach. In my case what I did was to record a video and check frame by frame 😅 .
Ok, I'll open a new PR applying the fix to the web version 👍 . |
2 tasks
|
@jd-alexander I've just opened the GB-mobile PR, let me know if you could take a look at it, thanks 🙇 . |
Sure, will do! |
vcanales
pushed a commit
that referenced
this pull request
Oct 27, 2021
…pproach (#35798) * Update logic of fetching calculation * Update react-native-editor changelog
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#4146
Description
This PR reverts the changes introduced in #33574 for fixing a loading glitch, and applies a different approach using the
hasFinishedResolutionselector to determine if the embed preview is being fetched.NOTE: These changes were motivated by the findings posted in this comment after debugging deeper the issue.
How has this been tested?
Follow the testing instructions from the reverted PR #33574 and verify that the original issue is not happening.
Screenshots
N/A
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).