Scripts: Add TypeScript for builds and tests #36260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Package] Scripts
gziolo
commented
Nov 5, 2021
|
I still need to update the documentation to reflect new capabilities added but code-wise it should be fully functional 😄 |
|
Size Change: 0 B Total Size: 1.08 MB ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/add-typescript-support-wp-scripts
branch
from
d41b5eb
to
57753fc
Compare
It's ready for review. |
mkaz
approved these changes
Nov 11, 2021
Both work. You can either use the TypeScript engine directly or Babel that also supports TypeScript syntax. I figured out it’s better to follow the way we handle TypeScript in Gutenberg with Babel. |
Ah right. Babel. I was so focused on webpack and its config. I didn't look at the babel-preset config. |
|
Is this already available? Because I'm using the latest wp-script 19.2.2 but does not compile the ts[x] files. |
|
Unfortunately, we are blocked by the release process for the next major WordPress version. It won’t be published to npm until January. We need to rethink the npm publishing process now that we got blocked for more than two months |
|
Thank you for your answer, for now I will try to use the script from @mkaz , it's a pity to wait untill jannuary |
|
So, for now I just copied the webpack config file in my directory and it seems to work. As soon as it will be released I will revert to the default version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inspired by https://github.com/mkaz/tsblock from @mkaz:
I thought that it would be great better TypeScript support directly to the WordPress packages. This PR improves configuration to make the build work with the example block.
How has this been tested?
../node_modules/.bin/wp-scripts buildto confirm that the build works as expected.../node_modules/.bin/wp-scripts startto confirm that the build works as expected.Screenshots
Types of changes
Checklist:
https://github.com/WordPress/gutenberg/blob/HEAD/docs/contributors/accessibility-testing.md -->