Rollback navigation areas #36604
Closed
Rollback navigation areas #36604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
requested review from
draganescu,
noisysocks,
talldan and
anton-vlasenko
adamziel
requested review from
ajitbohra,
nerrad,
spacedmonkey,
tellthemachines and
TimothyBJacobs
as code owners
adamziel
force-pushed
the
remove-navigation-areas
branch
from
0bd57df
to
565e773
Compare
|
Size Change: -509 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
+1 to removing navigation areas. I have never really understood why they are needed. We already have menu locations. We could reuse those, instead of reinventing the wheel with this new watch of locating mechanism. What do we think of finding way to pin a menu block to a location? |
One option might be to move the block behind the gutenberg/packages/block-library/src/index.js Line 238 in abff0e0 If the plan is to remove Navigation Area altogether, I'd suggest the following path:
|
38 tasks
This was referenced Nov 22, 2021
|
Once this is rebased we should be ready to rollback Navigation Areas. There now appears to be a consensus here that we should do that. |
|
Removing this from the board as #36727 is what we want for WP 5.9. (If I'm understanding things correctly.) |
|
With #36727 merged can this be closed? |
spacedmonkey
approved these changes
Nov 25, 2021
|
Would be good to get an update on this. I plan to remove the theme switching code as part of #36962, btw. I may also remove a few other things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #36524. This PR rolls back navigation areas.
Test steps
Confirm that all editors load properly, and the navigation block is being saved and rendered as expected.
Concerns
This block was shipped in Gutenberg 11.9, and now it's being reverted. It is hard to provide a fallback, too – it would essentially mean retaining the block. If Gutenberg is an "early preview" of the next WordPress, it should be okay to revert this PR. Still, I would like to get more opinions on that: @getdave @draganescu @noisysocks @talldan @mtias @youknowriad @jsnajdr @youknowriad @spacedmonkey @tellthemachines @azaozz @hellofromtonya.