New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E: Retry login again after a bad nonce request to prevent intermittent test failures #37219
Conversation
Size Change: +9 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
This might work. Care to bet a dogecoin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! The logic looks good to me, and retrying up to a few times looks like a good way of dealing with the potential race condition, if it fails more than that many times we've probably got a bigger problem that needs investigating.
LGTM! 🎉
Just adding the Backport to WP Beta/RC so that the WP release branch gets the e2e stability improvement, too 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 LGTM also 🤞 this will mean a lot less e2e reruns!
…ent test failures (#37219) * Testing whether we can try login again after a bad nonce request * Awaiting the undoing * Retry and return This might work. Care to bet a dogecoin? * Fix linting issue and add comment to explain the need for retry Co-authored-by: Glen Davies <glen.davies@a8c.com>
Description
The e2e tests intermittently fail due to some sort of race condition which causes the rest-api nonce to fail with a 400 error. This PR adds a login retry in these instances in order to make the test runs more resilient.
How has this been tested?
The e2e tests on this PR have be rerun multiple times
Props to @glendaviesnz @andrewserong @kevin940726