Fix the radio control checked property #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Dec 20, 2017
| @@ -32,7 +32,7 @@ function RadioControl( { label, selected, help, instanceId, onChange, options = | |||
| name={ id } | |||
| value={ option.value } | |||
There was a problem hiding this comment.
I think we can safely remove the value prop here, can we?
There was a problem hiding this comment.
I tried removing the value prop but the radio button never gets selected so it seems to be required.
There was a problem hiding this comment.
You're right! I don't know what happened in my testing 🙃
|
Sorry for the delay to review this PR. This got lost in the middle of the huge amount of PRs we have :) |
youknowriad
approved these changes
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The radio control is currently not displaying the checked value. This PR fixes the issue by changing the
selectedproperty tochecked.How Has This Been Tested?
Tested by adding a radio control to an inspector panel. The selected radio button is now displayed correctly when moving away and returning to the panel.
Types of changes
Bug fix
Checklist: