[Block Library - Query Loop]: Use gap for the grid view
#37711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
commented
Jan 4, 2022
| @@ -11,32 +11,21 @@ | |||
| list-style: none; | |||
| padding: 0; | |||
|
|
|||
| li { | |||
| clear: both; | |||
There was a problem hiding this comment.
This is unrelated, but couldn't find any reason for it being here.. It certainly seems like a leftover or wrong copy/paste 馃槃
|
Size Change: -328 B (0%) Total Size: 1.13 MB
鈩癸笍 View Unchanged
|
kjellr
approved these changes
Jan 5, 2022
|
Is this something worthy of a backport for 5.9? Four of the Twenty Twenty-Two patterns appear broken in RC1:
|
ntsekouras
added
the
Backport to WP Beta/RC
-cc @noisysocks |
|
Yep looks good to backport 馃憤 |
|
Fantastic, thanks so much for fixing this up @ntsekouras (and nice approach tidying up the styling via |
noisysocks
removed
the
Backport to WP Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 10, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #37681
Recently @andrewserong introduced React's
memoinPost Templateblock to avoid flickering when switching active block contexts. This added an extralielement which affected the css rule we had, as @iidastudio explained in the issue:So in this PR, I removed the
marginsand usedgapto achieve the same effect.Testing instructions
Everything should work as expected properly and no regression should be noticed 馃槃
In general we need to revisit this adhoc
layoutimplementation here and use thelayoutabstraction.