Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Late escape Archives block #37834

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Late escape Archives block #37834

merged 1 commit into from
Jan 11, 2022

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jan 10, 2022

Description

This is not a security problem. This PR simply moves escaping of all PHP output to be as "late" as possible. This means we avoid escaping variables until they are output in the HTML markup.

This is a WP Core best practice.

How has this been tested?

Check Archives block continues to output "as was" on the front end of the site.

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@getdave getdave added [Type] Code Quality Issues or PRs that relate to code quality [Type] Security Related to security concerns or efforts labels Jan 10, 2022
@getdave getdave assigned ehti and hellofromtonya and unassigned ehti and hellofromtonya Jan 10, 2022
@getdave getdave self-assigned this Jan 10, 2022
@getdave getdave added the [Block] Archives Affects the Archives Block label Jan 11, 2022
Mamaduka
Mamaduka approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, Dave.

@getdave getdave merged commit bb74294 into trunk Jan 11, 2022
@getdave getdave deleted the fix/archives-block-escape-late branch January 11, 2022 11:57
@github-actions github-actions bot added this to the Gutenberg 12.4 milestone Jan 11, 2022
@getdave getdave changed the title Move escaping to point of output in Archives block Late escape Archives block Jan 18, 2022
@getdave getdave mentioned this pull request Feb 7, 2022
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@TimothyBJacobs TimothyBJacobs TimothyBJacobs left review comments

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@hellofromtonya hellofromtonya Awaiting requested review from hellofromtonya

@ehti ehti Awaiting requested review from ehti

Assignees

@getdave getdave

Labels
[Block] Archives Affects the Archives Block [Type] Code Quality Issues or PRs that relate to code quality [Type] Security Related to security concerns or efforts
Projects
None yet
Milestone
Gutenberg 12.4
Development

Successfully merging this pull request may close these issues.
5 participants
@getdave @Mamaduka @TimothyBJacobs @ehti @hellofromtonya