New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement image block #379

Merged
merged 4 commits into from Apr 7, 2017

Conversation

Projects
2 participants
@aduth
Copy link
Member

aduth commented Apr 6, 2017

Related: #310

This pull request seeks to implement the core/image block. It should serve as a reference for a slightly more complex block type with multiple attributes, optional attributes, and selected state render handling.

Before After
Before After

Testing Instructions:

Verify that images in the sample Gutenberg post content are shown correctly, including caption. Selecting the image without caption should expand the selection. Per mockups we'd expect this to show placeholder text, but the <Editable /> component does not yet support placeholders (#378).

@aduth aduth referenced this pull request Apr 6, 2017

Closed

Add Block: Image #310

@aduth aduth force-pushed the add/image-block branch from 5b19aef to 1293313 Apr 7, 2017

@aduth aduth merged commit c057011 into master Apr 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aduth aduth deleted the add/image-block branch Apr 7, 2017

@mtias mtias added this to Documentation in Plugin Apr 12, 2017

@mtias mtias moved this from Documentation to Done in Plugin Apr 12, 2017

@afercia afercia added the Widgets label Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment