Implement image block #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Feature] Blocks
Closed
afercia
added
the
[Feature] Widgets Screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #310
This pull request seeks to implement the
core/imageblock. It should serve as a reference for a slightly more complex block type with multiple attributes, optional attributes, and selected state render handling.Testing Instructions:
Verify that images in the sample Gutenberg post content are shown correctly, including caption. Selecting the image without caption should expand the selection. Per mockups we'd expect this to show placeholder text, but the
<Editable />component does not yet support placeholders (#378).