Fix: Double border on palette editor. #38035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
|
Size Change: +85 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
fix/double-border-on-palette-editor
branch
from
eb463d6
to
14672dd
Compare
|
Thanks for this fix, @jorgefilipecosta… I'd love to review it when it's ready. |
Hi @javierarce, it should be ready for review. Did you face any issues while testing it? |
|
I've tested this fix and it works well. It would be very nice to apply a similar solution to the rest of the lists in the Global Style sidebar (I thought your fix would also improve how those other items are rendered).
|
aristath
approved these changes
Jan 20, 2022
The palette editor component because of allowing edits and having special interactions is not the same component as Elements we should look into applying a similar solution to other parts of the sidebar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #37962 (comment).
This PR fixes an issue on the color palette editor where the selected color appear with two borders one in gray (the default border) and one in blue (the selected border).
After this PR is merged only the blue border appears.
cc: @javierarce