Site Logo: Avoid unnecessary re-renders #38316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Site Logo
|
Size Change: -13 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
aristath
reviewed
Jan 28, 2022
aristath
approved these changes
Jan 28, 2022
|
I'm going to merge this, failing e2e tests is known to be flaky. |
|
Oh, good catch. Thanks for adding this PR! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another small performance tweak.
Similar to #38285 and #38292.
The Site Logo block was re-rendering when typing in the editor since returned
mediaItemDatawas a new object every time.Testing Instructions
Types of changes
Performance
Checklist:
*.native.jsfiles for terms that need renaming or removal).