Prefer kses to blanket esc_html on label #38696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug introduced when adding additional escaping to the output of blocks whereby any rich formatting or HTML would be output in it's raw form.
This PR refines the approach to use
wp_kses_post
which sanitizes input with allowed HTML elements for post content. This affords more flexibility whilst still warding off anything nefarious.Kudos to @randhirexpresstech for catching and reporting this one.
Testing Instructions
Display the title as a link
and alsoInclude the label as part of the link
.wp_kses_post
deems acceptable for Post content.Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.js
files for terms that need renaming or removal).