NumberControl: refactor to TypeScript
#38753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Enhancement
|
Size Change: -1.6 kB (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
refactor/number-control-typescript
branch
from
f3455d2
to
b47c769
Compare
… to `UnitControl`
This was referenced Feb 22, 2022
|
Closing as a good chunk of the work has been done in #43791. The remaining work is around typing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #35744
For ease of review, it's recommended to take also a look at the changes commit-by-commit
TODO:
NumberControloutside of the@wordpress/componentspackageNumberControlconsumers to extend its propsTesting Instructions
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).