Block Editor: insertDefaultBlock should not trigger an error if the default block is not registered
#38886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
ellatrix,
ajitbohra,
mkaz and
ryanwelcher
as code owners
Mamaduka
added
[Package] Block editor
|
Size Change: +12 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
jsnajdr
approved these changes
Feb 17, 2022
|
Thanks for the review, @jsnajdr. |
cbravobernal
changed the title
insertDefaultBlock should not trigger an error if the default block is not registered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the default block isn't registered the
insertDefaultBlocktriggers the following Redux error:Testing Instructions
Running this e2e test shouldn't print the error above -
npm run test-e2e -- packages/e2e-tests/specs/editor/various/block-deletion.test.jswp.data.dispatch('core/blocks').removeBlockTypes('core/paragraph');Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).