TreeGrid: Add tests for callback functions #38942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Feature] UI Components
|
Size Change: +120 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
andrewserong
changed the title
12 tasks
andrewserong
removed
the
[Status] In Progress
ramonjd
approved these changes
Feb 22, 2022
|
Thanks for the review @ramonjd! I'll merge this in now since it doesn't affect any of the component's behaviour, but let me know if anyone would like me to make any changes, and I'm happy to follow up. |
andrewserong
deleted the
add/unit-tests-for-tree-grid-callback-functions
branch
ciampo
added
[Package] Components
ciampo
reviewed
Feb 22, 2022
There was a problem hiding this comment.
Thank you @andrewserong for adding these tests!
Just a question — is there a reason why, in the tests, we're using "vanilla" tr and tds instead of TreeGridRow and TreeGridCell ?
Merged
8 tasks
|
Thanks for taking a look @ciampo! I actually ran into some errors with
So, since I was primarily testing the contract of the callbacks, I thought the vanilla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following on from the ListView multi-select behaviour added in #38314, this PR adds test coverage for the TreeGrid component's callback functions, to ensure that the expected contract is maintained when we make changes to the component. This includes:
onExpandRowcallback, that returns the DOM element for the row to be expandedonCollapseRowcallback, that returns the DOM element for the row to be collapsedonFocusRowcallback, that returns the event that was fired, the starting row DOM element, and the destination row DOM elementTesting Instructions
From the command line run the following:
Screenshots
Types of changes
Code quality / test coverage.
Checklist:
*.native.jsfiles for terms that need renaming or removal).