TreeGrid: Update callback unit tests to use TreeGridRow and TreeGridCell sub components #39002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ell sub components
andrewserong
added
[Feature] UI Components
11 tasks
|
Size Change: +10 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
|
LGTM - should this one also be updated at the same time? |
|
Good thinking, thanks @glendaviesnz I've updated that test and the snapshot too 👍 |
|
Thank you @andrewserong and @glendaviesnz ! |
andrewserong
deleted the
update/tree-grid-test-to-use-row-and-cell-sub-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a quick follow-up to #38942 to update the
TreeGridcomponent's tests for its callback methods to use theTreeGridRowandTreeGridCellsubcomponents so that the tests better match real world usage of the component. Thanks for the feedback @ciampo!Testing Instructions
Check that the CI jobs pass, or test locally via:
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).