[RNMobile] Small refinements to upload error message #38951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 21, 2022 11:44
With this commit, the error message's copy is tweaked to make it as clear as possible that users need to tap for more information about the error.
The text in the error message is aligned to the centre for various blocks with this commit. This follows design feedback.
SiobhyB
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
|
👋 @iamthomasbishop, this has the tweaks you suggested in wordpress-mobile/gutenberg-mobile#2448 (comment). Looking forward to hearing whether this matches what you were thinking or if you have any further ideas! |
|
@SiobhyB The copy looks good, thanks for that! Just want to confirm one thing: we're still showing the ActionSheet/Dialog (the one that contains the "Retry" and "Cancel"/"Remove" buttons) when you tap on the error message, correct? |
iamthomasbishop
approved these changes
Mar 8, 2022
|
Thank you @iamthomasbishop!
That's right, this PR doesn't make any changes to the ActionSheet/Dialog, which will continue to have the "Retry" and "Cancel" options. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#4597Addresses design tweaks that were requested here: wordpress-mobile/gutenberg-mobile#2448 (comment)
Description
This PR includes a couple of small refinements to upload errors that display within media upload blocks. Those refinements include the following:
Failed to insert media. Please tap for options.toFailed to insert media. Tap for more info.The purpose of this change is to make it clearer that a more verbose, specific error message can be found by tapping on the failed upload.Testing Instructions
Steps to test:
Screenshots
Types of changes
Small, non-breaking changes to an error message's copy and text alignment.
Checklist:
*.native.jsfiles for terms that need renaming or removal).