Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberControl: commit (and constrain) value on blur event #39186

Merged
merged 14 commits into from
Mar 21, 2022
Merged

NumberControl: commit (and constrain) value on blur event #39186

merged 14 commits into from
Mar 21, 2022

Commits on Mar 17, 2022

  1. InputControl: always commit value to internal state on blur

    @ciampo
    ciampo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    e3bc714 View commit details
    Browse the repository at this point in the history

  2. NumberControl: constain value also on the UPDATE action

    @ciampo
    ciampo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    b2f2138 View commit details
    Browse the repository at this point in the history

  3. CHANGELOG

    @ciampo
    ciampo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    bb15bd2 View commit details
    Browse the repository at this point in the history

  4. Add unit test

    @ciampo
    ciampo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    823cf7b View commit details
    Browse the repository at this point in the history

  5. Remove UPDATE action from InputControl s state reducer

    @ciampo
    ciampo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    a1c6fc7 View commit details
    Browse the repository at this point in the history

  6. Add unit test to check that onChange gets called when the value is … 

    …clamped on `blur`
    @ciampo
    ciampo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    1e5123c View commit details
    Browse the repository at this point in the history

  7. Fix input control blur logic, so that onChange is called after clam… 

    …ping the value
    @ciampo
    ciampo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    6f5696e View commit details
    Browse the repository at this point in the history

  8. Comments

    @ciampo
    ciampo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    5db0df6 View commit details
    Browse the repository at this point in the history

  9. Use event.target.validity.valid in docs, storybook and unit tests

    @ciampo
    ciampo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    f6d2654 View commit details
    Browse the repository at this point in the history

  10. README

    @ciampo
    ciampo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    1154566 View commit details
    Browse the repository at this point in the history

  11. Add docs and update example about input validity

    @ciampo
    ciampo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    046ca57 View commit details
    Browse the repository at this point in the history

  12. Update onChange event type

    @ciampo
    ciampo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    5a6154f View commit details
    Browse the repository at this point in the history

  13. Override event.target, update types

    @ciampo
    ciampo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    43ff576 View commit details
    Browse the repository at this point in the history

  14. Revert docs and Storybook changes about target.visibility potential… 

    …ly not being defined
    @ciampo
    ciampo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    dad09a5 View commit details
    Browse the repository at this point in the history