-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Image block link rel handling #39319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
Issues or PRs that relate to code quality
label
Mar 9, 2022
Size Change: -18 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Good to close this old issue 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9731
What?
When adding a link to the image block and marking it as an external link, the "rel" of the link is not being updated properly.
This doesn't have any visible impact in the image block because when saving and loading the page, the ref attribute get filled again (by parsing the DOM after the server side filter adding the rel="noreferrer noopener" does its job). That said, it's not idea, the block is not idempotent.
Why?
It's mostly a code quality to change to make the image block "link" behave similarly to the RichText links.
How?
I'm just assigning the "noreferrer noopener" rel attribute when the "open in new tab" is triggered and remove these two rel attributes when the "open in new tab" is removed.
Testing Instructions
Screenshots or screencast
Screen.Recording.2022-03-09.at.5.01.25.PM.mov