Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX missing images of Gutenberg Data Apps document #39499

Merged
merged 3 commits into from
Mar 28, 2022

Conversation

atachibana
Copy link
Contributor

All images in "Create your first app with Gutenberg Data" are shown on GitHub preview, but not in the Block Editor Handbook. For example, the following page contains the image after "app will look like this:" but does not show:
https://developer.wordpress.org/block-editor/how-to-guides/data-basics/

This is because the image is specified as below:

! [](/docs/how-to-guides/data-basics/media/list-of-pages/part1-finished.jpg)

It must be

!  [](https://raw.githubusercontent.com/WordPress/gutenberg/HEAD/docs/how-to-guides/data-basics/media/list-of-pages/part1-finished.jpg)

As like as other images on doc page.
Refer https://github.com/atachibana/gutenberg/blob/master/docs/how-to-guides/plugin-sidebar-0.md.

At the same time, I also modified two minor typos.

@gziolo gziolo requested a review from adamziel March 22, 2022 07:16
@gziolo gziolo added [Type] Developer Documentation Documentation for developers [Type] Bug An existing feature does not function as intended labels Mar 22, 2022
@gziolo
Copy link
Member

gziolo commented Mar 22, 2022

Thank you for starting this PR. @adamziel should be interested to help you to bring it to the finish line.

@atachibana
Copy link
Contributor Author

atachibana commented Mar 26, 2022

@gziolo @adamziel
Hi, I noticed @adamziel fixed 2 files of not showing images at commit cb92180 , but still 1 file remains.

I also included some typo or old link fixes in this chapter.

@gziolo
Copy link
Member

gziolo commented Mar 27, 2022

Hi, I noticed @adamziel fixed 2 files of not showing images at commit cb92180 , but still 1 file remains.

What's still missing? Should we land all the changes applied so far?

@atachibana
Copy link
Contributor Author

@gziolo
Though you've already approved, I'll add comments for clarity.

Missing are in the 3-building-an-edit-form.md.
Please see the below generated page in the handbook that does not have any images:
https://developer.wordpress.org/block-editor/how-to-guides/data-basics/3-building-an-edit-form/

Should we land all the changes applied so far?

Yes. I believe this PR resolves all.

@gziolo gziolo merged commit 7cd1fd5 into WordPress:trunk Mar 28, 2022
@gziolo
Copy link
Member

gziolo commented Mar 28, 2022

Thank you @atachibana 💯

@github-actions github-actions bot added this to the Gutenberg 13.0 milestone Mar 28, 2022
@adamziel
Copy link
Contributor

@atachibana Thank you so much! 💯 ❤️

@atachibana
Copy link
Contributor Author

atachibana commented Mar 31, 2022

@adamziel Hi, Thank you for the educational and fun tutorial.

By the way, did you know the Japanese guy Aki Hamano (@t-hamano ) is doing the live-demo based on your tutorial? (Ah, sorry it is Japanese... )
https://www.youtube.com/watch?v=X2KiGkPcPYY
He is also famous with Piano Block.

@adamziel
Copy link
Contributor

adamziel commented Apr 1, 2022

I had no idea, thank you so much for sharing that @atachibana ❤️

@t-hamano I would love to learn more about your experience with that tutorial! Was it smooth? Confusing? Anything that was missing in your opinion, or any specific direction that you'd like to see it expanded in? I certainly have blind spots for things and your feedback would help me notice and pay attention to them.

As a side note, you might be interested in the upcoming Part 4 that explains how to build a form that enables creating new pages.

And by the way, the Piano Block is amazing!

@t-hamano
Copy link
Contributor

t-hamano commented Apr 1, 2022

@adamziel Thank you for making a great tutorial.
And thanks to @atachibana for translating it into Japanese!

I'm just now putting that tutorial into practice, but I would like to send the issue or PR if there is any concern 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants