[RNMobile] Remove bottom padding from picker bottom sheet on Android #40056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchowning
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.22 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes some extra bottom padding from the bottomsheet picker on Android. I noticed this extra padding when looking at a different issue, and @iamthomasbishop confirmed that we want to remove it. I'm not sure this fix gets us to the ideal state, but it seems like a definite improvement.
Why?
It's not clear to me why this padding was added initially, but I'm guessing that some other change must have removed the need for it at some point.
How?
Testing Instructions
Take a look at the bottom sheet picker component and make sure nothing looks off. In particular, a few good things to make sure and check are:
It would be good to also explore other bottom sheet components to make sure I'm not unintentionally breaking something else with this change.
Screenshots
Gallery Block -> Settings -> Link to
Choose [Media]
Latest Posts Block -> Customize -> Order By [OR] Category