Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update individual block locking section #40372

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Docs: Update individual block locking section #40372

merged 2 commits into from
Apr 18, 2022

Conversation

Mamaduka
Copy link
Member

What?

Changes in this PR:

  • Removed the experimental warning.
  • Added an example of how individual block locking could be used with templates.

@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label Apr 15, 2022
@Mamaduka Mamaduka self-assigned this Apr 15, 2022
@Mamaduka Mamaduka requested a review from annezazu April 15, 2022 07:17
alexstine
alexstine approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs make sense to me. 👍 Would be good to get a non-technical point of view on this though. 🙂

@Mamaduka
Copy link
Member Author

Thanks, @alexstine.

annezazu
annezazu approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@annezazu annezazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor, non blocking comment but this looks great to me. Thanks for evolving these docs.

docs/reference-guides/block-api/block-templates.md Outdated Show resolved Hide resolved
@Mamaduka Mamaduka merged commit 443dc7f into trunk Apr 18, 2022
@Mamaduka Mamaduka deleted the update/block-templates-docs branch April 18, 2022 06:58
@github-actions github-actions bot added this to the Gutenberg 13.1 milestone Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexstine alexstine alexstine approved these changes

@annezazu annezazu annezazu approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@mkaz mkaz Awaiting requested review from mkaz

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

Assignees

@Mamaduka Mamaduka

Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 13.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Mamaduka @alexstine @annezazu