Components: Unify black color to gray-900 #40391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -57 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Apr 18, 2022
There was a problem hiding this comment.
Excellent work, @mirka ! It feels good to review this kind of clean-up PRs 🎉
I just noticed that the label in InputControl (and descendant components) is still using pure black in Storybook. The reason seems to be this line of code — I quickly tried deleting it and it seemed to work fine, although I'm not sure why that rule was there in the first place 🤞
Finally, I also noticed that the changes in #40119 seem to have made it impossible to type a value interactively in the InputControl's stories, and opened #40410 to fix that separately.
Perfect, thanks for catching and debugging (3886ff9)! I agree it looks safe to remove. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40113
Related to #40387
What?
Heading: Replace usage of#050505with gray-900.Affected components
AlignmentMatrixControlInputControlHeadingSelectControlSpinner (Experimental)TextOnly the color reference changed and not the color value
SurfaceWhy?
Our default black is now gray-900, and some components had incorrect or outdated blacks.
Testing Instructions
Smoke test the affected components in Storybook.