Stop exporting individual color objects from color values file #40387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
mirka
force-pushed
the
avoid-color-value-exports
branch
from
efa2fca
to
9fc51f4
Compare
|
Size Change: -8 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #40392
What?
Removes individual exports from the color values file.
Why?
To clean up the color values file (as discussed), we need to start de-duping the color references that are already being used.
Removing individual exports should also prevent devs from newly referencing these color objects while we're still cleaning up.
How?
The colors used in the
Navigationcomponent have been replaced with canonical references to the exact same color values (i.e. no colors have actually changed).Testing Instructions
✅
npm run buildstill works✅ The
Navigationcomponent should have the same colors as before