Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ColorPalette component's documentation #40620

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

daviedR
Copy link
Contributor

@daviedR daviedR commented Apr 26, 2022

What?

https://developer.wordpress.org/block-editor/reference-guides/components/color-palette/

The className property is documented to have default value of Select or Upload Media which is not true, so we should remove it.

Why?

className property is not required, and has no default value.

How?

Remove the particular line from the documentation.

Testing Instructions

Screenshots or screencast

The `className` property is documented to have default value of `Select or Upload Media` which is not true, so we should remove it.
@daviedR daviedR requested a review from ajitbohra as a code owner April 26, 2022 12:52
@skorasaurus skorasaurus added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components labels Apr 26, 2022
@alexstine alexstine requested a review from ciampo April 28, 2022 14:02
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mirka mirka merged commit adf74e8 into WordPress:trunk Apr 29, 2022
@github-actions github-actions bot added this to the Gutenberg 13.2 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants