Update react-dates to 21.8.0
#40801
Merged
Update react-dates to 21.8.0
#40801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Code Quality
|
Size Change: +4.61 kB (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
noisysocks
force-pushed
the
try/update-react-dates
branch
from
bebb91c
to
867a0f2
Compare
ciampo
approved these changes
May 5, 2022
There was a problem hiding this comment.
LGTM 🚀
The fact that react-dates doesn't have a CHANGELOG with what's changed across versions doesn't help, but during my testing I couldn't find any regressions.
The package seems actively maintained, but the latest release is almost 2 years old — IMO we should consider alternatives.
ciampo
moved this from In progress (owned) ⏳
to In progress ⏳ (un-owned)
in WordPress Components
There was a problem hiding this comment.
@ciampo was too fast for me 🚀
I tested this as well.
- Publish popover looked & worked ok
- DateTimePicker story works well
- Tests still pass
Haha although the score at this point is probably like Marco 1 - Aaron 93 😅 |
|
Thanks for reviewing! I found a changelog here just FYI. Not a lot that concerns our usage of the package, really. https://github.com/react-dates/react-dates/blob/master/CHANGELOG.md |
|
Thank you for surfacing the changelog! I had previously looked into the "releases" section and somehow missed completely the CHANGELOG file 😅 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the
react-datesdependency of@wordpress/componentsto 21.8.0.Why?
I was hoping that updating
react-dateswould fix theconsole.warn()that is emitted becauseDayPickerusescomponentWillReceivePropswhich is deprecated. Unfortunately it does not.Still, it's probably worth updating the package anyway so that we have the latest bug fixes and security fixes.
How?
I bumped the version in
packages/components/package.jsonand rannpm install.Testing Instructions
This PR is based off of #40754 which includes tests. You can also:
DateTimePickerstory to check that there is nothing off.