-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Navigation Link: add design controls (color, text decoration, and font family) #41378
Conversation
While color is obvious the others are not that clear. Will all fonts we have in that dropdown provide those arrows? As you said, the decoration is even more questionable, what would an all caps strike through "next" symbol do? I think let's add just the color and open an issue about the text options. Maybe we can move away from text in the block? |
No I don't think so, which is why being able to choose the font family I think is useful. I agree text decoration is unnecessary, will remove it from this PR. |
😁 thanks for the update @jffng Excuse my persistence, but I am still unclear what font family is for because:
|
Yeah I think font family is potentially confusing here. Shall we reduce it to just color? |
I agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, let's merge.
845465d
to
1eb834d
Compare
e2e admin tests failing, tried to rebase but it didn't help. |
What?
Adds experimental controls for link color, text decoration, and font family to the Post Navigation Link block.
Why?
It would be useful to control these style attributes via the editor. Text decoration is maybe questionable, but I think the link color and font family are additions whose use cases should be evident.
How?
Updates the theme's block.json
Testing Instructions
Screenshots or screencast
cc @WordPress/block-themers