-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome: Hide several Sidebar Panels if the CPT doesn't support it #4161
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f3deebe
Chrome: Hide the Featured Image Panel if the CPT doesn't support it
youknowriad 6f27c2b
Chrome: Hide the discussion panel if no support for comments or track…
youknowriad e7ce755
Chrome: Hide the PostAuthor selector if the CPT doesn't support it
youknowriad b69920a
Chrome: User the PostTypeSupportCheck to check Post Formats support
youknowriad 0fe2322
Chrome: Hide revisions if the CPT doesn't support it
youknowriad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
/** | ||
* Internal dependencies | ||
*/ | ||
import PostTypeSupportCheck from '../post-type-support-check'; | ||
|
||
function PostFeaturedImageCheck( props ) { | ||
return <PostTypeSupportCheck { ...props } supportKeys="thumbnail" />; | ||
} | ||
|
||
export default PostFeaturedImageCheck; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,41 +1,10 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import { connect } from 'react-redux'; | ||
import { get } from 'lodash'; | ||
|
||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { withAPIData } from '@wordpress/components'; | ||
import { compose } from '@wordpress/element'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import { getCurrentPostType } from '../../store/selectors'; | ||
import PostTypeSupportCheck from '../post-type-support-check'; | ||
|
||
function PostFormatCheck( { postType, children } ) { | ||
if ( ! get( postType.data, [ 'supports', 'post-formats' ] ) ) { | ||
return null; | ||
} | ||
|
||
return children; | ||
function PostFormatCheck( props ) { | ||
return <PostTypeSupportCheck { ...props } supportKeys="post-formats" />; | ||
} | ||
|
||
export default compose( [ | ||
connect( | ||
( state ) => { | ||
return { | ||
postTypeSlug: getCurrentPostType( state ), | ||
}; | ||
}, | ||
), | ||
withAPIData( ( props ) => { | ||
const { postTypeSlug } = props; | ||
|
||
return { | ||
postType: `/wp/v2/types/${ postTypeSlug }?context=edit`, | ||
}; | ||
} ), | ||
] )( PostFormatCheck ); | ||
export default PostFormatCheck; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
every
? I could imagine a need for both cases, i.e. a component that requires post type support for both X and Y, but alternatively X or Y.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hesitated on adding an "operator". For now we only have the "or" use-case.