-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Full Site Editing]: Include theme's templates in template list in post editor #41630
Conversation
1ff6d0b
to
4f94b40
Compare
4f94b40
to
cf5aab8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested classic themes by adding theme support for block-templates to Twenty Twenty.
I tested block themes by adding a PHP template to Twenty Twenty-Two.
The PR solves the problem. The added context in the comment is clear.
Thanks for the quick repair on this; the regression had been affecting me as well; and I can also confirm this PR fixes the issues I experienced. |
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
This was a small regression so the fix restored the previous functionality. No need for dev note. |
What?
Fixes: #41617
Regression from: #41387
Why?
In the PR that caused the regression, I overrode the
templates
that were coming fromget_page_templates
(core) but that made the php theme templates lost. This PR fixes that by excluding only the needed templates.Testing Instructions
templates
directory.Screenshots or screencast