Global Styles: Add block CSS rules after the Global Styles rules #41934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
approved these changes
Jun 24, 2022
|
This is solving the original issue for me, but now other blocks are more specific than the elements rules in theme.json. In my testing, the search block rules in packages/block-library/src/search/style.scss are applying before the ones in theme.json |
|
Size Change: -68 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
Ok, I still see a few things that are different from what I expected. I'm testing with this markup: And with this theme.json content on Block Canvas:
What I notice:
|
|
Thanks @MaggieCabrera, those two points should now be addressed... |
MaggieCabrera
approved these changes
Jun 24, 2022
This was referenced Aug 4, 2022
Closed
Hey, the result of this PR is that the block CSS overrides theme and user preferences, breaking the whole styles algorithm. I've been out for a while and may be missing things, but with the info I have today I suggest we revert this change. Can we explore a path like #34180 to solve the issues of the button block? |
This was referenced Aug 9, 2022
37 tasks
|
I see that we reverted these changes back at #43022 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This changes the load order of CSS for blocks to make it dependent on Global Styles. This means that the block CSS will load after Global Styles
Fixes #41918
Why?
Now that the block CSS also contains user's settings, it's necessary to load it after the Global Styles CSS, since these rules are meant to take priority.
How?
wp_register_styletakes a dependencies array as an argument, which determines load order. By settingglobal-stylesas the dependency, we ensure that block CSS loads later than the main Global Styles stylesheet.The problem is that moving these styles later means that they now override button element styles. To overcome this:
Testing Instructions
Using the Remote theme, add a buttons block to your post. The buttons should be yellow, not grey.
Other things to test:
Screenshots or screencast
See #41918
Note
This will probably break other things - if there are rules set in block CSS and then overridden in Global Styles for example...
Also, before we merge this we'll need to copy this function to the compat folder.
@WordPress/block-themers