Post Author block now includes option to link author archive

[philwp]

What?

Adds a toggle option to add a link to the Author's archive page.

Why?

Resolves #41554

How?

If the linked attribute is true

Testing Instructions

1. Open the Site Editor
2. Select a template such as Home
3. Add Post Author block.
4. Toggle Link author name to author page

Screenshots or screencast

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @philwp! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[paaljoachim]

Thank you for creating this PR @philwp

@michalczaplinski and @c4rl0sbr4v0 Perhaps you can take a look at this PR?

[cbravobernal]

Thank you very much for your contribution!! I added some small details.

[cbravobernal]

We may better use isLink, so that way is similar to other blocks like:

gutenberg/packages/block-library/src/site-logo/block.json

Line 13 in ac4d4b0

"isLink": {

gutenberg/packages/block-library/src/site-title/block.json

Line 17 in ac4d4b0

"isLink": {

Also would be cool to have a default value here.

[cbravobernal]

This part is working fine, but, maybe, in order to keep consistency with other blocks, we could do:

1. Define the default author name: $author_name = get_the_author_meta( 'display_name', $author_id );
2. Update the value if the link attribute is enabled:

if ( ! empty( $attributes['isLink'] ) && ! empty( $attributes['linkTarget'] ) ) {
		$comment_author = sprintf( '<a rel="external nofollow ugc" href="%1s" target="%2s" >%3s</a>', esc_url( $link ), esc_attr( $attributes['linkTarget'] ), $comment_author );
	}

3. Check if rel attribute is needed, add a target option.

Comment Author Name block is an example you can use 😄

gutenberg/packages/block-library/src/comment-author-name/index.php

Lines 37 to 39 in ac4d4b0

	if ( ! empty( $attributes['isLink'] ) && ! empty( $attributes['linkTarget'] ) ) {
	$comment_author = sprintf( '<a rel="external nofollow ugc" href="%1s" target="%2s" >%3s</a>', esc_url( $link ), esc_attr( $attributes['linkTarget'] ), $comment_author );
	}

[philwp]

Thanks! I'll update to match the implementation used in comment-author-name.

[cbravobernal]

@philwp , we need to run in order to pass all the tests, thanks for your contribution to the project! 🎉

• npm run docs:build when we add a new attribute to a block to update the documentation
• npm run format:php to use the code standards on whitespace in PHP
• npm run lint:js:fix to use the code standards on whitespace in JS

[cbravobernal]

@philwp , sorry, in order to pass the JS unit tests, as you added new attributes to a block, you have to regenerate the fixtures.
Please, run npm run fixtures:regenerate and only add the files changed with core__post-author in the name.

Thanks!!

[github-actions]

Congratulations on your first merged pull request, @philwp! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!