[Site Editor] Archive-PostType template UI #42746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
|
Size Change: +257 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jul 28, 2022
jorgefilipecosta
force-pushed
the
add/archive-post-type-template-ui
branch
from
1717871
to
aba0f14
Compare
|
Hi @ntsekouras, |
jorgefilipecosta
force-pushed
the
add/archive-post-type-template-ui
branch
2 times, most recently
from
ab58c8b
to
eceb21d
Compare
ntsekouras
force-pushed
the
add/archive-post-type-template-ui
branch
from
eceb21d
to
639f0be
Compare
jorgefilipecosta
force-pushed
the
add/archive-post-type-template-ui
branch
from
639f0be
to
a55c55f
Compare
Sure, I will do that 👍 I think this PR is ready to merge and just needs approval cc: @ntsekouras, @oandregal. |
jorgefilipecosta
force-pushed
the
add/archive-post-type-template-ui
branch
from
a55c55f
to
44c1c65
Compare
jorgefilipecosta
force-pushed
the
add/archive-post-type-template-ui
branch
from
44c1c65
to
c538786
Compare
|
👋 I've tested by:
|
|
A couple of things I've noticed:
220825-error-loading-template-screen.webm
220825-templates-loading-async.webm |
|
Merging this PR, according to @oandregal (and my own tests) seems to work well and the issue identified is not because of this PR. In case someone notices a possible enhancement just leave a comment and I will create a follow-up PR. |
|
PR to fix the template page blank screen at #43602 |
ntsekouras
reviewed
Aug 25, 2022
cbravobernal
changed the title
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Sep 21, 2022
Backports PHP changes in WordPress/gutenberg#42746 to the core. Adds a has_archive field to the post types endpoint. Props mcsf, ntsekouras, oandregal. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54273 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Sep 21, 2022
Backports PHP changes in WordPress/gutenberg#42746 to the core. Adds a has_archive field to the post types endpoint. Props mcsf, ntsekouras, oandregal. See #56467. Built from https://develop.svn.wordpress.org/trunk@54273 git-svn-id: http://core.svn.wordpress.org/trunk@53832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Sep 21, 2022
Backports PHP changes in WordPress/gutenberg#42746 to the core. Adds a has_archive field to the post types endpoint. Props mcsf, ntsekouras, oandregal. See #56467. Built from https://develop.svn.wordpress.org/trunk@54273 git-svn-id: https://core.svn.wordpress.org/trunk@53832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
30 tasks
ootwch
pushed a commit
to ootwch/wordpress-develop
that referenced
this pull request
Nov 4, 2022
Backports PHP changes in WordPress/gutenberg#42746 to the core. Adds a has_archive field to the post types endpoint. Props mcsf, ntsekouras, oandregal. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54273 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to create an archive-posttype template on the site editor UI.
It uses the same UI as Single Posts and Taxonomies.
Part of: #37407
Testing Instructions
I verified I could create archive templates for posts and pages, and the UI shown below appears on the add new template menu.