(Custom)SelectControl: Truncate long options #43301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
mirka
force-pushed
the
fix/select-overflow
branch
from
f596245
to
e316d46
Compare
ciampo
reviewed
Aug 17, 2022
| @@ -137,6 +137,9 @@ export const Select = styled.select< SelectProps >` | |||
| width: 100%; | |||
| max-width: none; | |||
| cursor: pointer; | |||
| overflow: hidden; | |||
There was a problem hiding this comment.
Is there a reason why we're using raw CSS instead of the Truncate component? (I'm ok with both, just curious)
There was a problem hiding this comment.
I don't think there is a placement that works in this case with the <select>. The main reason though is for encapsulating the styles within the styled Select export so it can be reused in CustomSelectControl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43098
What?
Truncate long option strings in SelectControl/CustomSelectControl.
Why?
The components look broken without it.
How?
With standard string-truncating CSS.
Testing Instructions
Can be tested in either Storybook or WP.
Storybook
npm run storybook:devwidthto a wrapper div so the options overflow.WP
npm run devoptionto make the text overflow.✅ Tested with
width: fit-contenton the container✅ Tested in Chrome/Firefox/Safari
Screenshots or screencast