-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List Item: Adopt typography supports #43312
Conversation
This worked well in the post editor, but when I set the typography supports in global styles, on saving the changes are reverted - I wonder it is related to this being experimental? list-item.mp4 |
Thanks for catching that @glendaviesnz 👍
I'll dig into this later today. The experimental status of the ListItem block could perhaps mean it is filtered from the merged global styles. Given the experimental status, I don't think there's any rush in getting these supports in place for 6.1. |
f878ba2
to
ec93887
Compare
Rebased this, and even though the list v2 is not experimental anymore the list item typography supports don't save in global styles still. |
The values are being serialised into the global styles custom post:
but it looks like I can't see anything obvious missing from the block registration that is causing this. Should we just move this to the blocked column for now @aaronrobertshaw as not critical as the font family can at least be set on the parent? |
If I install the WP 6.1 RC, the I wonder if this is another caching or timing related issue for theme.json processing? As in, this code is running before Gutenberg registers or re-registers its blocks. Looks like #44658 could be related. |
I think I found the issue here. When the List Item block landed in core, it wasn't added to the list of blocks for Gutenberg to override the implementation of. When I add that there, then the List Item definitely shows in the Global Styles block, has the Gutenberg added block supports, and the styles generate, save & apply correctly. I'll put up a PR to fix that later today. |
ec93887
to
3cda4f2
Compare
I've rebased this PR to pick up the fix from #44911. Should be right for a final review ✅. @glendaviesnz, I believe you've already tested this PR with the fix, is there anything else you think needs tweaking? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related:
What?
Adds all typography support to the List Item block.
Why?
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2022-08-17.at.6.59.05.pm.mp4