AlignmentMatrixControl: Improve stories #43438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +432 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
Maybe I'm testing the wrong way, but 2a6501727b8cec264be400c491c5e2c9.mp4 |
|
Thanks for testing!
|
My feeling is that I prefer either of the following responses:
But I think it's fine as it is, and I'll leave the final decision up to you 😊 |
t-hamano
approved these changes
Aug 22, 2022
|
I added a |
|
Thanks for responding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35665
What?
Improves the stories to:
onChangevalues from the Actions tab.Why?
For easier testing.
Testing Instructions
npm run storybook:devand see the stories for AlignmentMatrixControl.