Update: Improve content locking on media & text block. #44036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +87 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ZebulanStanphill
added
[Type] Enhancement
|
Is there an issue or previous discussion related to this PR? |
|
Hi @carolinan, |
|
It's working for me, but it's a bit strange that the blue outline doesn't 'hug' the image when you select it, and instead seems to fill the container:
Will we need to make this change for all circumstances where images exist in templatelocked containers? 😟 |
Hi @jameskoster, that happens even without this PR/and content locking. The media & text block contains the media and the text blocks on the side, so it is expected that the blue line encompasses all the area.
Yes, the image blocks have custom-made controls where the block itself is the one that needs to decide which controls are content and which ones are not. |
It seems a bit strange to behave this way, but we can look into it separately.
How about when images are placed in content-locked Covers, Columns, Tables, Quotes, etc 🤔 |
they already work well, the implementation at the image level covers every block where the image is nested in.
Yes, I guess we can open an issue and look into it, it is something totally unrelated to content locking. |
Just to add, it covers everything where the image block is nested in even galleries. The media & text block is an exception case. It has an image but does not use the image block it is totally different block that's the only reason that makes this PR needed. |
jameskoster
approved these changes
Sep 13, 2022
jorgefilipecosta
deleted the
update/improve-content-locking-on-media-text-block
branch
bph
added
the
Backport to Gutenberg RC
cbravobernal
pushed a commit
that referenced
this pull request
Sep 15, 2022
ockham
added
the
Backport to WP 6.7 Beta/RC
|
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: bb4752b |
ockham
pushed a commit
that referenced
this pull request
Sep 19, 2022
ockham
removed
the
Backport to WP 6.7 Beta/RC
15 tasks
aaronrobertshaw
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes alignment options, image positioning, and image resizing from media and text block when there is content locking.
cc: @jameskoster
Testing Instructions
I pasted the following block on the code editor:
I verified the block options of media & text were restricted.