Most used tags: Try fixing label #44859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
commented
Oct 11, 2022
| @@ -1,3 +1,4 @@ | |||
| .interface-interface-skeleton__actions, | |||
There was a problem hiding this comment.
So this is obviously a big change, given it's SCSS. But at the moment, it targets the entire inspector, why shouldn't it target also the pre-publish inspector? Would love a sanity check on this one. Thank you!
There was a problem hiding this comment.
Just speaking from a general CSS architecture standpoint, this kind of thing isn't encouraged because it breaks component encapsulation. Styles for InterfaceSkeleton should not live in a different component's folder.
And assuming that the reason you want to do this is to get these uppercase styles ☝️, this kind of styling (targeting all h3s) also isn't generally tenable in a componentized app.
So my quick fix suggestion for this specific issue would be to change this:
to:
<BaseControl.VisualLabel as="h3" className="editor-post-taxonomies__flat-term-most-used-label">
{ label }
</BaseControl.VisualLabel> so we can get the label styles cleanly. Let me know if you need further assistance, and I can push a commit to this branch if you would like.
There was a problem hiding this comment.
Please feel free to push to this branch!
Thank you.
|
Size Change: +59 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Oct 11, 2022
|
Thanks. I'll let this one sit for others to chime in on, since it isn't particularly urgent. |
This reverts commit 3f4f335.
mirka
approved these changes
Oct 14, 2022
|
It does! Nice, thank you!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Most used tags is a thin weight:
I think it was designed for a previous style of labels that weren't small and uppercase. This PR just removes the font weight:
The prepublish interface was also missing the style entirely:
I made a biggish change to the code that styles the default inspector, to also encompass the pre-publish sidebar. I'll comment in the code and ask for an extra look:
Testing Instructions
Have at least 4 different labels, and 3 of them used on a bunch of posts. Then observe the Tags sidebar, and the pre publish tag suggestion dialog.