Navigation: Remove filters disabling tabs for link and submenu

[aaronrobertshaw]

Related:

• Set "Settings" as default tab on split inspector #47575
• Block Inspector: Make Settings tab the default #47592

What?

Removes the filters for Navigation Link & Submenu blocks that disable block inspector tab display.

Why?

Once #47592 lands, the settings tab will be the default tab. It was the need to display the settings tab by default when we couldn't programmatically change the tab selection that led to these filters being introduced.

How?

Delete the filters disabling tabs from each block.

Testing Instructions

1. Apply the changes from Block Inspector: Make Settings tab the default #47592 as well as this PR.
2. Add a Navigation block containing a submenu and additional links.
3. Select the Navigation block and click the edit button beside the submenu within the Nav block's List View tab.
4. The Navigation Submenu block should not display tabs, as it has no controls for the Styles tab.
5. Navigate back to the Navigation block. This time click the edit icon beside one of the Navigation Link blocks in the List View tab.
6. Ensure the Navigation Link block shows both the Settings and Styles tabs. Settings should be selected by default.

Screenshots or screencast

Screen.Recording.2023-01-31.at.3.50.33.pm.mp4

[getdave]

Will test once #47592 lands. Thank you for considering the need to retain "Settings" as the default tab for these blocks.

[talldan]

I rebased it when testing locally to bring in some other recent changes - removal of the offcanvas editor button and 'settings' as the first tab. There are also now 'dimension' tools for the submenu block.

It's working really well, and feels more consistent than earlier version:

Kapture.2023-02-01.at.14.17.30.mp4

[getdave]

Nice work here @aaronrobertshaw 👏