Navigation: Update the dependencies for the useEffect that handles notifications #48066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +12 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a253a51. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4173038895
|
draganescu
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This useEffect doesn't list all of its dependencies.
Why?
Not listing all dependencies can cause unexpected bugs.
How?
Add the dependencies to the array.
Testing Instructions
5. If you have a classic menu, try converting it to navigation menu. 6. Try creating a new navigation by adding a block to a fallback navigation. 7. Try editing a navigation block that has innerblocks set in a theme.Testing Instructions for Keyboard
As above, but for step 4, check that you hear a message saying:
Creating Navigation Menu.