test: Improve mobile editor performance tests #48101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance tests often only assert the performance of a component via `measurePerformance`. This change adds `measurePerformance` to the list of functions that are considered assertions to avoid erroneous lint warnings.
- Remove unnecessary lint warning disable line caused by erroneous placement of `screen` argument. - Query UI components via user-facing attributes, e.g. a11y label. - Pass mock function to required `onChange` prop to `RichText` component.
dcalhoun
added
[Type] Automated Testing
dcalhoun
requested review from
ellatrix,
fluiddot,
gziolo,
ntwb,
nerrad and
ajitbohra
as code owners
dcalhoun
added
the
Mobile App - i.e. Android or iOS
dcalhoun
commented
Feb 15, 2023
Comment on lines
+3
to
+8
| rules: { | ||
| 'jest/expect-expect': [ | ||
| 'error', | ||
| { assertFunctionNames: [ 'expect', 'measurePerformance' ] }, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
As referenced in the Reassure docs, this has the linter consider measurePerformance an assertion.
It is possible there may be a better location to place this new configuration, but the test-unit file did seem appropriate.
There was a problem hiding this comment.
Ah, good call. I agree this is better than forcing the other assertions.
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
To avoid web test scripts from including the performance files for the native mobile editor, we must include the term "native" in the file name. This renames the test files to follow the existing pattern of not including "test" in the file name.
|
Flaky tests detected in 648c104. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4185834653
|
derekblank
approved these changes
Feb 16, 2023
Comment on lines
+3
to
+8
| rules: { | ||
| 'jest/expect-expect': [ | ||
| 'error', | ||
| { assertFunctionNames: [ 'expect', 'measurePerformance' ] }, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
Ah, good call. I agree this is better than forcing the other assertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Address test failures and lint warnings in mobile editor performance tests.
Why?
The tests should pass without lint warnings.
How?
measurePerfomrancean assertion.RichTextperformance test by leveragingscreento query thesubject component.
Testing Instructions
n/a
Testing Instructions for Keyboard
Screenshots or screencast
n/a