Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Improve mobile editor performance tests #48101

Merged
merged 3 commits into from Feb 16, 2023
Merged

test: Improve mobile editor performance tests #48101

merged 3 commits into from Feb 16, 2023

Commits on Feb 15, 2023

  1. test: Linter considers measurePerfomrance an assertion 

    Performance tests often only assert the performance of a component via
`measurePerformance`. This change adds `measurePerformance` to the list
of functions that are considered assertions to avoid erroneous lint
warnings.
    @dcalhoun
    dcalhoun committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    675c29e View commit details
    Browse the repository at this point in the history

  2. test: Fix errors in Rich Text performance test 

    - Remove unnecessary lint warning disable line caused by erroneous
  placement of `screen` argument.
- Query UI components via user-facing attributes, e.g. a11y label.
- Pass mock function to required `onChange` prop to `RichText`
  component.
    @dcalhoun
    dcalhoun committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    81212dc View commit details
    Browse the repository at this point in the history

  3. test: Rename native editor performance test files 

    To avoid web test scripts from including the performance files for the
native mobile editor, we must include the term "native" in the file
name. This renames the test files to follow the existing pattern of not
including "test" in the file name.
    @dcalhoun
    dcalhoun committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    648c104 View commit details
    Browse the repository at this point in the history