Rich text: copy tag name on internal paste #48254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3.34 kB (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b4b681d95cce3ec478ad077b064d863df3ce71e3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5658725076
|
|
That's strange, it's working for me... We're setting the clipboard on the paste event, so it shouldn't be dependent on the browser.
|
ellatrix
force-pushed
the
try/copy-paste-heading
branch
2 times, most recently
from
1a8fafd
to
d0689c4
Compare
There was a problem hiding this comment.
The pull request is working for me now in Chrome Version 110.0.5481.100 on Mac:
CleanShot.2023-02-21.at.05.26.04.mp4
The scenario still fails on trunk, so it seems like this is a fix (and not that my browser changed in some way).
I only started experiencing this bug recently. Any ideas what might've changed?
|
I'm not sure. I think this behaviour has been around for a while |
ellatrix
force-pushed
the
try/copy-paste-heading
branch
from
d0689c4
to
30da760
Compare
|
I tried this in Safari and nothing would paste, this is what I got:
|
|
Same thing in Chrome, I tried reinstalling and rebuilding, but the same thing happened.
|
|
Hi team, just following up on the progress here following a discussion ahead of RC1. If we can confirm that this issue is caused by a browser change and can get a fix in place by RC2 (next week), this PR can get included in 6.2. Otherwise, we will need to punt. Thanks! |
|
According to the issue, it's been around for a long time so it's probably fine to punt? |
|
Hi @ellatrix, this PR is on the 6.3 project board since it was punted from 6.2. But it's been a while since this was worked on. Is this still something we are aiming to get into 6.3, or should I remove it from the board? |
|
I keep seeing this so I'm going to punt it :) |
|
Sorry, got distracted with other work, I'll have a look into. |
ellatrix
force-pushed
the
try/copy-paste-heading
branch
from
30da760
to
b4b681d
Compare
|
Should be fixed now. Not sure how it was even working before. |
ellatrix
force-pushed
the
try/copy-paste-heading
branch
from
b4b681d
to
09948a7
Compare
apeatling
approved these changes
Jul 26, 2023
@danielbachhuber |
|
@apeatling Something about my local machine seems fubar, unfortunately. |
|
I think this one looks good to merge either way. 👍 |
|
I'll address the e2e test failures on Monday |
ellatrix
force-pushed
the
try/copy-paste-heading
branch
from
150c1cd
to
802fe10
Compare
ellatrix
force-pushed
the
try/copy-paste-heading
branch
from
802fe10
to
09c707c
Compare
ellatrix
requested review from
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
Thanks for driving this over the finish line, @ellatrix ! 🙌 |
SiobhyB
added
the
[Feature] Rich Text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
After copying a heading that is entirely or partially selected, pasting it into a paragraph doesn't copy over the heading tag name.
Why?
Fixes #48040.
How?
When setting the html content on paste, copy the tagName context. On paste this can then be used to create a blocks array.
This PR also changes internal paste to go through the
pasteHandlerpath for better consistency in paste handling.Testing Instructions
Select all text in a heading and copy. Paste it in an empty paragraph. The heading should be preserved.
Testing Instructions for Keyboard
Screenshots or screencast